ES6 in README code #172
Merged
ES6 in README code #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related discussion: Stance on var vs. let & const? d3/d3#3435 |
Fil
reviewed
Dec 20, 2020
|
Oh nice idea! Will iterate. |
|
Made that change. Thanks @Fil for reviewing! |
This was referenced Mar 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was reading through the README and noticed ES5 in the sample code. In fact there was mixed ES5 and ES6 (some arrow function expressions, and some ES5 functions).
This PR unifies the sample code to consistently use ES6, including
let,const, and arrow function expressions.